Conversation
rpj
requested changes
Jun 20, 2022
| env_file: | ||
| - .local.env | ||
| volumes: | ||
| - ./content:/content |
Owner
There was a problem hiding this comment.
I like the .env file thing a lot (honestly can't recall if I've ever used that!), but the removal of SPRING83_CONTENT_DIR_HOST won't work because ./content isn't where I keep them on my system. I'd prefer to keep that as an env for now (just because I'm lazy and it's already in my .bashrc). Overall though I don't disagree that this isn't ideal: there has to be a better way right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the environment variables into a file.
It would be nice to be able to define
SPRING83_CONTENT_DIR_HOSTin that env file too, but I wasn't able to easily get that to work. I just defined the volume and path directly in the docker-compose file. It's simpler but may not be as good as what was there before.